-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Golang versions automatically when new patch version is released #86
Conversation
Q: Should it not be a group so that it updates all places where it sees a golang-version (e.g. |
Even when i use |
I'd say they are grouped because of the last rule in the renovate file: coreint-automation/renovate-base.json5 Lines 79 to 84 in 186d8f6
|
I just thought changes like this or this could also be handled with this. But it is completely okay to leave it for later. |
Makes sense. Thanks. |
renovate-base.json5
Outdated
"matchUpdateTypes": ["patch"], | ||
// Exclude any dependencies which are pre-1.0.0 because those can make breaking changes at any time | ||
// according to the SemVer spec. | ||
"matchCurrentVersion": "!/^(0|v0)/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this doesn't apply to Go versions since they are all already v1
as of now, but good to have it around nonetheless 👌
…d also overcome redundancy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Changes in this PR:
golang version
golang patch version
golang version
but disabled automergegolang patch version
groupSteps that I went through to test the auto-merge works as expected
TestCase-1: If there is a new GoLang Patch version released the renovate bot should auto-merge the PR.
coreint-automation/renovate-base.json5
and added it to forkednri-mysql/.github/renovate.json5
TestCase-2: If there is a new GoLang minor version released the renovate bot should raise PR but not auto-merge it.