Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOSSA composite action exit code #76

Merged
merged 1 commit into from
Jun 4, 2024
Merged

FOSSA composite action exit code #76

merged 1 commit into from
Jun 4, 2024

Conversation

elaguerta-nr
Copy link
Contributor

@elaguerta-nr elaguerta-nr commented Jun 3, 2024

The if the FOSSA CLI errors, the check shows up as a red X on all PRs, in particular PRs to public repos. We want to suppress these so that contributors and consumers do not need to worry about the checks, for the following reasons:

  • scans do not address security risk
  • rulesets are still in the Evaluation period
  • the failing check is not the fault of external contributors.
    Errors will still be logged to the job logs.

This means the check will show up as green, so that contributers/consumers of public repos do not have to worry about it.
@elaguerta-nr elaguerta-nr changed the title Fixup error code Exit 0 Jun 3, 2024
@elaguerta-nr elaguerta-nr changed the title Exit 0 FOSSA composite action exit code Jun 3, 2024
@elaguerta-nr elaguerta-nr marked this pull request as ready for review June 3, 2024 23:16
@cmboling
Copy link

cmboling commented Jun 3, 2024

point blank simple! lgtm 🚀

@elaguerta-nr elaguerta-nr merged commit cc2985f into main Jun 4, 2024
13 checks passed
@elaguerta-nr elaguerta-nr deleted the fixup-error-code branch June 4, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants