Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for odds, ends, and gotchas #5

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

casewalker
Copy link
Collaborator

No description provided.

@casewalker casewalker requested a review from a team December 12, 2023 20:11
Copy link

@jasnoo jasnoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation!

confusing UI, I believe an AWS support engineer did submit a request to change
it so the info box goes away when everything is correctly configured.

Where to configure the base URL

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this line be formatted as a ## title (then adjusting the below title too)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh good catch, I think this was a note from me while writing the doc, should be removed now! TY!

@casewalker casewalker merged commit 82b9a14 into main Dec 13, 2023
1 check passed
@casewalker casewalker deleted the more-docs branch December 13, 2023 21:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like I'm becoming privy to some classified information.

Comment on lines +3 to +19
This code functions to bring together AWS Cognito with AWS Connect using the
Lambda defined in the
[Custom AWS IDP](https://github.com/newjersey/custom-aws-idp)
repo. It utilizes Cognito's
[Hosted UI](https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pools-hosted-ui-user-sign-in.html)
so that the baseline login security is fully managed by AWS (with JWTs
containing login session metadata). In order to send invite-emails to new users
and manage password resetting, AWS Simple Email Service (SES) has been used to
register a verified domain and a verified email. The Cognito User Pool is also
configured to require MFA. One of those MFA methods is allowed to be SMS, and
setting up the phone number for those text messages is done in Amazon Simple
Notification Service (SNS) and Amazon Pinpoint / Pinpoint SMS.

To make this all work took some unintuitive steps and some long lead times, so
this document serves to help anyone in the future trying to replicate or emulate
some parts of this system as well as to update the right things if this system
changes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may just be me, but I feel like it'll be more readable in a bulleted list, each bullet corresponding to a service?

## Generating (and handling) a valid SAML Response

As described in the README for Custom AWS IDP, there was a lot of difficulty
generating a valid, signed SAML Response which AWS could consume. As well,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatically, the "As well" feels off here, maybe "Also"? Similarly below, maybe I just haven't heard that

## Setting up emails

We wanted to set up Cognito's *Messaging* configuration so that users would be
able to get an invitation-email with their first (temporary) password and also

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invitation email, perhaps no need for hyphen


We wanted to set up Cognito's *Messaging* configuration so that users would be
able to get an invitation-email with their first (temporary) password and also
so that users could receive emails to help for forgotten-password resets. As it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no need for hyphen here too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave this one, I agree about the above hyphen, but I think this one is good to have to help explain the type or reset.

able to get an invitation-email with their first (temporary) password and also
so that users could receive emails to help for forgotten-password resets. As it
turned out, this was much harder than it seemed, requiring enough understanding
of email security and the AWS Email Service (SES) to get to the point where

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple Email Service to avoid confusion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants