Added speed to public api (get and monitor) #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… because of sleep
sroebert
force-pushed
the
feature/speed
branch
2 times, most recently
from
2a13995
to
4e27e02
Compare
…or for height and speed, next to just height
sroebert
force-pushed
the
feature/speed
branch
from
4e27e02
to
29a5dd1
Compare
|
Thanks for the feature! This and #409 have are in v0.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #409, this PR makes the speed value of the desk public api. You can either:
get_speedto get the current speedget_height_and_speedto get a tuple of both height and speedFor backwards compatbility you can still monitor with a callback that only accepts one parameter, which just gets called for height changes.