-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crime Assist pda program (DeltaV) #993
base: master
Are you sure you want to change the base?
Conversation
* Completely untested first commit * Get basic program flow working * Add Innocent * Add Fancy Rich Text * Icon Thanks, IcedQuinn! * Add Cartridge icons * New image from IcedQuinn * Add explanation on what a Sophont is, to be automatically appended to any text referencing a Sophont later on * Convert tabs to spaces * remove [bold] tags from loc * Make text bold again * Alter formatting, reduce text length for sophont explanation to fit it on the screen * Update Resources/Locale/en-US/deltav/cartridge-loader/cartridges.ftl Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Tim Falken <[email protected]> * Add program to more PDA's * Add a tip about the app * Recreate flow in yaml todo: actually load and use this yaml * Remove the old state machine, and add configurable yaml prototypes to define pages * Move page to its own file --------- Signed-off-by: Tim Falken <[email protected]> Co-authored-by: Colin-Tel <[email protected]>
* Create CrimeassistTest.cs * Fix invalid crimeasssist entries * Clean up test code
…tier-station-14 into 2023-12-31-CrimeApp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that crimeassistflow.yml scares me, and I assume this still needs to be all rewritten for our space law. My only real concern (other than trying to comprehend the crimeassistflow.yml) is that its another location in the codebase that we need to remember to update any time theres a change in space law.
Luckily theres a test written for it that makes it a lot harder to break stuff https://github.com/DeltaV-Station/Delta-v/blob/594f56445829c1a95e2a251b785a7ffb63fc874a/Content.IntegrationTests/Tests/DeltaV/CrimeassistTest.cs It wont auto update, but you cant easily have invalid entries |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…tier-station-14 into 2023-12-31-CrimeApp
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the PR
Add a Crime Assist program, which helps NFSD and Lawyer players determine what crime was committed without having to have a wiki open.
Why / Balance
For many players, evidently, reading up on Space Law is an insurmountable obstacle, and as a result they have trouble identifying what is and isn't a crime. For this reason, a PDA program that gives a basic way to see what sort of crime was committed may help.
Technical details
The PDA program is fairly simple. It has a ew buttons (Start, Home, Yes, No) which are visible/invisible depending on the program's State. This State also determines which Localization string is displayed.
The laws are based on DeltaV and will need changes done for Frontier to be fully working.
Media
DeltaV-Station/Delta-v#464
Breaking changes
N/A
Changelog
🆑 Master2112