Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ship Design: NT Liquidator - Dedicated Janitorial Vessel #543

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Nov 8, 2023

About the PR

A small ship (175 tiles) equipped with everything one might need to make even the dirtiest ship squeaky clean (ducky slippers included). Notable features:

  • Wide array of janitorial supplies, a drain, a sink, and material/biomass recyclers;
  • Small chemlab for cases when janitor needs to clean potassium spills;
  • Small scale atmo setup for cleaning and replacing atmosphere in a ship if needed;
  • Hull shape resembles Light Replacer tool (yet not entirely devoid of function);
  • Galoshes!

Why / Balance

According to my unsystematic observations that I absolutely can not back with statistics, by the mid-shift ships tend to become rather untidy (especially science oriented vessels) and sometimes it goes so far that air in them becomes barely breathable. Given that as of right now there are no dedicated janitorial vessels in the shipyard I decided that I can submit a design of such vessel.

Media

2023-11-08_09 17 17
Figure 1 - Map editor screenshot without subfloor and spawn view
2023-11-08_09 17 04
Figure 2 - Map editor screenshot with subfloor and spawn view turned on
2023-11-10_07 22 12
Figure 3 - "In game" screenshot after you buy it from shipyard

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • added NT Liquidator - a dedicated janitorial vessel

Contact info
Discord username: erhardsteinhauer

@dvir001
Copy link
Contributor

dvir001 commented Nov 9, 2023

Your change log just going to say "NT Liquidator" unless you fix it
Jani cart need to be spawner
Axe storage no axe?

@ErhardSteinhauer
Copy link
Contributor Author

ErhardSteinhauer commented Nov 9, 2023

Your change log just going to say "NT Liquidator" unless you fix it

What should I put in the changelog for the first commit? Sorta added the whole ship hence just its name in changelog.

Jani cart need to be spawner

I don't have janicart mapped there at all. Or are you talking about janitorial trolley?

Axe storage no axe?

I used an entity named "Fire Axe Cabinet [Filled]". Axe was present when I tested the ship despite the sprite on screenshots suggesting otherwise.

@IData-RedactedI
Copy link
Contributor

For the change log, put something like (added the liquidator, a dedicated janitorial ship).

@ErhardSteinhauer ErhardSteinhauer changed the title Add NT Liquidator New Ship Design: NT Liquidator - Dedicated Janitorial Vessel Nov 10, 2023
@ErhardSteinhauer
Copy link
Contributor Author

Updated PR title, changelog and added captions to screenshots. Also provided my discord contact.

@Cheackraze
Copy link
Member

your price is too low, the cost of the ship is 24,201 so you should probably aim more for the 28-32k range for the cost of the ship.

Also, i know its pretty much cramped in there, but a janidrobe vending machine might be a better fit than maybe the stack of clothes. And a portable scrubber would be a good addition as well, since you can also then clean player's air.

@Cheackraze Cheackraze merged commit 1cca3c3 into new-frontiers-14:master Nov 12, 2023
8 of 9 checks passed
FrontierATC added a commit that referenced this pull request Nov 12, 2023
dvir001 pushed a commit to dvir001/frontier-station-14 that referenced this pull request Jan 1, 2024
* Make felinids meow it instead of sayin it.

A note: snapping doesnt even make a sound effect on humans. Only putting it just incase that ever gets fixed upstream.
Also fixes issue new-frontiers-14#525
A simple PR.

* Hopefully fixes yaml linter.

* Removes notes.
Cheackraze pushed a commit that referenced this pull request Jan 2, 2024
* Fluffy tail for felinids (#433)

* Fluffy tail for felinids

After 9 years. I finished it.

(Requires Phil's approval, will put it to ready for review as soon as he gets to see fully the fully finished PR)

* An small update.

Updated meta.json to include all numbers to be equal.
Updated PNG to allow updated numbers to have actual sprites and not just empty sprites.

* Improved the tail sprite.

Proper animation and code.

* Updates ftl for it to properly work.

* Prevent shooting while inside a duffelbag (#510)

Anyone shoved into a duffelbag gets an ItemComponent. This denies anyone
with an ItemComponent from shooting a gun.

* Prevent pseudoitems from being transferred between bags  (#553)

* Update PseudoItemSystem.cs

* Rider full cleanup

* Also abort in sharedstorage

* Make the comp shared

* Why drop the bags?

* Make felinids meow it instead of sayin it. (#543)

* Make felinids meow it instead of sayin it.

A note: snapping doesnt even make a sound effect on humans. Only putting it just incase that ever gets fixed upstream.
Also fixes issue #525
A simple PR.

* Hopefully fixes yaml linter.

* Removes notes.

* Fixing

* FTL fix

* Missing FTL

* fix tattoos

* Updates more variation of mraowing. (#604)

Thats it.

* Allow vulpkaning to sigh. (#569)

Nothing much. Just a small quality of life.

* What the hell is even a yeep?

* Update felinid.yml

---------

Co-authored-by: Adrian16199 <[email protected]>
Co-authored-by: Bakke <[email protected]>
Co-authored-by: Debug <[email protected]>
@ErhardSteinhauer ErhardSteinhauer deleted the Liquidator branch January 31, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants