Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PlantHolderSystem.cs #542

Closed
wants to merge 6 commits into from
Closed

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Nov 7, 2023

About the PR

Fix abuse of a broken game design with mutation of plants.

@@ -534,7 +534,7 @@ public void Update(EntityUid uid, PlantHolderComponent? component = null)
foreach (var (gas, amount) in component.Seed.ExudeGasses)
{
environment.AdjustMoles(gas,
MathF.Max(1f, MathF.Round(amount * MathF.Round(component.Seed.Potency) / exudeCount)));
MathF.Max(0.1f, MathF.Round(amount * MathF.Round(component.Seed.Potency) / exudeCount)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after some lengthy discussion on discord, I think a better solution would be to take frezon out of the possibilities for mutations instead of just omega nerfing the amount. The other fix is fine, no stacking gas types still, but having both these combined is too much of a nerf.

Copy link
Contributor Author

@dvir001 dvir001 Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill look into this, I think its using all gasses so ill try to replace it with an array.

@dvir001
Copy link
Contributor Author

dvir001 commented Dec 6, 2023

Fixed in new PR

@dvir001 dvir001 closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants