Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making some slight updates and fixes to the Comet #517

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Making some slight updates and fixes to the Comet #517

merged 1 commit into from
Nov 1, 2023

Conversation

Shodhans
Copy link
Contributor

@Shodhans Shodhans commented Oct 31, 2023

About the PR

This PR covers some very minor changes to the Comet, nothing major or groundbreaking, just a few things that got missed on release.

Why / Balance

Some things are just minor QOL changes, others were issues pointed out to me by people who had flown the Comet themselves and come to the conclusion a few things could be changed/fixed/added. I don't believe any of these changes substantially change the way it operates or the benefits that it gives.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

https://youtu.be/qhkFQC1FbO0

Breaking changes

Changelog

  • fix: Fixed CometShip thruster that was disabled by default
  • tweak: Shut Comet Ship captain's locker that had been left open by default
  • add: Put a pair of insuls and engineering goggles to the Comet Ship CE locker that had been intended to be in there, but was forgotten
  • tweak: Moved Comet Ship's bridge's 'panic button' from its location on the window slightly further back, as people were able to press the panic button from either side in its original place
  • add: Added shutters to Comet Ship covering the windows to the bridge that are linked to the panic button, as it was pointed out that locking yourself in a room with only windows might not be a good idea if the enemy has lasers. Airlocks do not have shutters over them.
  • fix: Fixed Comet Ship's AME shielding rotation

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changlog is extremly confusing.

A reminder that the changlog will not mention your PR/Ship.
I recomend to change your changelog to one line or mention the Comet ship.

Example:

  • tweak: Comet Ship recived some maintenance.

or:

  • fix: Comet Ship AME is now in the correct rotation.
  • tweak: Comet Ship panic button location has changed.
    ect...

@Shodhans
Copy link
Contributor Author

Will do, apologies for the confusion!

@Cheackraze Cheackraze merged commit a5f3c28 into new-frontiers-14:master Nov 1, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants