Fix attempt to job priority #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
No C#
YML
Status: Needs Review
|
First test i do: select Pilot as highest, Contractor is medium, and i spawn as a contractor, doesnt seem right |
Not fixing that bug, fixing the bug when you actually have it set to "never" yet somehow get selected as it. |
GreaseMonk
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
From testing this fix the bug about selecting a job you have set to "never" eg, putting you as pilot or merc when you select contractor.
Why / Balance
Bug fix
How to test
Select only contractor, ready up, start game.
If you manage to only spawn as contractor in about 10 tests you can 100% confirm its fixes since before this fix I got merc that was set to never every other round restart.
Media
N/A
Requirements
Breaking changes
N/A
Changelog
N/A