Moved Victory and Shibamata from lobby to jukebox #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
|
Make sure to convert them to mono, I think lobby music is stereo by default |
Bless, fixed |
GreaseMonk
approved these changes
Jan 10, 2025
FrontierATC
added a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Compare the 2 song to the rest that are alot more light on volume level and you find out that when new players join without changing music levels they get attacked by loud music.
Why / Balance
We didnt have the jukebox before for this use, now we do.
How to test
Lobby all calm music or not bombastic, open jukebox to find the music.
Media
N/A
Requirements
Breaking changes
N/A
Changelog
🆑