Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respawn Lenience (based on Corvax) #1894

Merged

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Aug 21, 2024

About the PR

Reduces respawn timers when entering cryosleep, timers "stay running" when in a ghost role unless the role dies. Meant to incentivize players taking ghost roles, and entering cryosleep when finished with their shift. Mostly a work in progress at the time of writing.

Based on Corvax-Frontier#191 (many thanks to @FireNameFN), though with significant modifications at time of writing.

Why / Balance

This is one part of improvements to cryosleep. Reopening job slots automatically becomes more feasible when station/department job holders that enter cryosleep can choose another job without much delay. Even players that die may be less reluctant to take a ghost role or spend more time in-game if the respawn timer will not reset on them.

How to test

TBD

Media

TBD

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

At the time of writing, there is a new cryosleep event before a user's mind is removed, otherwise all public APIs are identical.

Changelog

🆑

  • tweak: Respawn timers now start from when you die or ghost, and are not reset when taking or leaving a ghost role.
  • tweak: When entering cryo, your respawn timer is reduced (default 30 seconds). If you re-enter, you will receive a longer timer.

@whatston3 whatston3 changed the title Respawn Leniance (based on Corvax) Respawn Lenience (based on Corvax) Aug 21, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Aug 23, 2024
@dvir001 dvir001 removed the S: Merge Conflict This PR has conflicts that prevent merging label Aug 24, 2024
@whatston3 whatston3 marked this pull request as ready for review August 29, 2024 19:53
@dvir001 dvir001 self-requested a review September 7, 2024 11:33
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Sep 7, 2024
@dvir001 dvir001 merged commit ae3e69e into new-frontiers-14:master Sep 7, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Sep 7, 2024
@whatston3 whatston3 deleted the 2024-08-21-cryo-and-respawns branch September 21, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants