-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respawn Lenience (based on Corvax) #1894
Merged
dvir001
merged 13 commits into
new-frontiers-14:master
from
whatston3:2024-08-21-cryo-and-respawns
Sep 7, 2024
Merged
Respawn Lenience (based on Corvax) #1894
dvir001
merged 13 commits into
new-frontiers-14:master
from
whatston3:2024-08-21-cryo-and-respawns
Sep 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respawn timer fix
…-station-14 into 2024-08-21-cryo-and-respawns
whatston3
changed the title
Respawn Leniance (based on Corvax)
Respawn Lenience (based on Corvax)
Aug 21, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
S: Merge Conflict
This PR has conflicts that prevent merging
label
Aug 23, 2024
…-station-14 into 2024-08-21-cryo-and-respawns
dvir001
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Reduces respawn timers when entering cryosleep, timers "stay running" when in a ghost role unless the role dies. Meant to incentivize players taking ghost roles, and entering cryosleep when finished with their shift. Mostly a work in progress at the time of writing.
Based on Corvax-Frontier#191 (many thanks to @FireNameFN), though with significant modifications at time of writing.
Why / Balance
This is one part of improvements to cryosleep. Reopening job slots automatically becomes more feasible when station/department job holders that enter cryosleep can choose another job without much delay. Even players that die may be less reluctant to take a ghost role or spend more time in-game if the respawn timer will not reset on them.
How to test
TBD
Media
TBD
Breaking changes
At the time of writing, there is a new cryosleep event before a user's mind is removed, otherwise all public APIs are identical.
Changelog
🆑