Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique glove fibers (#1455) #1645

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Unique glove fibers (#1455) #1645

merged 3 commits into from
Jul 10, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jul 10, 2024 •
edited
Loading

DeltaV DeltaV-Station/Delta-v#1455

This also revert
#1439

And fix missing fiber colors for frontier gloves

@WarMechanic @deltanedas @dvir001
Unique glove fibers (new-frontiers-14#1455)
0f97acb 
* make changes

* comments

* commiting a single whitespace so i dont get executed

---------

Co-authored-by: deltanedas <[email protected]>
@github-actions github-actions bot added the C# label Jul 10, 2024
@github-actions github-actions bot added the YML label Jul 10, 2024
@github-actions github-actions bot added the FTL label Jul 10, 2024
whatston3
whatston3 reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will test.

Resources/Prototypes/_NF/Entities/Clothing/Hands/gloves.yml
Comment on lines +50 to +51
- type: Fiber
fiberColor: fibers-cream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 It has been done.

whatston3
whatston3 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! Something that seems odd though is that a glove doesn't automatically have its own fiberprint, it has to be put on first.

@whatston3 whatston3 merged commit 9b001af into new-frontiers-14:master Jul 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatston3 whatston3 whatston3 approved these changes

Assignees
No one assigned
Labels
C# FTL YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvir001 @whatston3 @WarMechanic