Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Optimize Debris Code" #1383

Merged
merged 1 commit into from
May 18, 2024
Merged

Revert "Optimize Debris Code" #1383

merged 1 commit into from
May 18, 2024

Conversation

Cheackraze
Copy link
Member

About the PR

its just deleting people now, needs a revert

@Dysh3s
Copy link

Dysh3s commented May 18, 2024

I believe it was fixed by Corvax-Frontier#80

@dvir001
Copy link
Contributor

dvir001 commented May 18, 2024

Im doing the fix PR

@dvir001
Copy link
Contributor

dvir001 commented May 18, 2024

I believe it was fixed by Corvax-Frontier#80

We have that code, can it be something else?

@dvir001
Copy link
Contributor

dvir001 commented May 18, 2024

#1384
Fixed, please merge.

@dvir001 dvir001 closed this May 18, 2024
@Cheackraze Cheackraze reopened this May 18, 2024
@Cheackraze
Copy link
Member Author

It's also causing tps hitching with 5 whole ms to calculate the queue, this needs reverting

@dvir001
Copy link
Contributor

dvir001 commented May 18, 2024

It's also causing tps hitching with 5 whole ms to calculate the queue, this needs reverting

Isnt it helping overall since before it it seemed like they didn't de-spawn at all

Fixed public TimeSpan MaximumTickTime { get; } = TimeSpan.FromMilliseconds(1);

@dvir001 dvir001 self-requested a review May 18, 2024 16:31
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label May 18, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to fix it all in ones

@dvir001 dvir001 merged commit b89bf7e into master May 18, 2024
27 checks passed
@Cheackraze Cheackraze deleted the revert-gc-may-2024 branch November 26, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants