-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expedition Early Finish #1380
Expedition Early Finish #1380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs a check to make sure that all the participants are on board so that malicious actors cant perma delete people like that
Fair, as a side note it will need Humanoid and also to make sure it has a mind since it used to "bug" from cult and syndicates (A more simple fix will be to ignore them since they have contraband comp) Will do. |
Corvax-Frontier#155 |
… into 2024-05-17-Expo
… into 2024-05-17-Expo
Still needs a small fix to the expedition console to print out a "not everyone is onboard" message on hitting the finish early button, but apart from that, this should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaned up the bit I added for the salvage cvar listener and set, the stateless one should be less prone to bugs. Tested on my side, happy with how this works.
About the PR
Based on code from Frontier Corvax.
Corvax-Frontier@4cf5a6a
Why / Balance
Allow ending expo without having to wait for the timer to end.
How to test
Spawn expo ship, start expo, the computer will now allow you to end expo from it.
Media
Breaking changes
N/A
Changelog
🆑