Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port "Added north line to shuttle console" from Corvax #1375

Merged

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented May 17, 2024

About the PR

Ported "Added north line to shuttle console" PR by @FireNameFN: Corvax-Frontier#154
I just added comments.

Why / Balance

Greatly helps navigation

How to test

Buy shuttle, observe thin red line pointing northward when you rotate

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame

Breaking changes

idk

Changelog
🆑 erhardsteinhauer

  • add: Added north line to shuttle console GUI (code by @FireNameFN)

@VividPups
Copy link
Contributor

If you add a line to that, Is there a way you could see if you could add an line to tell expedition ships if they are far enough from an object ot be able to FTL is that possible?

@ErhardSteinhauer
Copy link
Contributor Author

If you add a line to that, Is there a way you could see if you could add an line to tell expedition ships if they are far enough from an object ot be able to FTL is that possible?

Don't think it should be done this way. I believe it'll be better if FTL button on expedition menu would grey out if you can't use it.

@ErhardSteinhauer ErhardSteinhauer marked this pull request as ready for review May 18, 2024 07:27
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, going to wait for another code review.

@ErhardSteinhauer
Copy link
Contributor Author

@FireNameFN, pinging you to make sure, if you are fine with this PR.

@FireNameFN
Copy link
Contributor

@FireNameFN, pinging you to make sure, if you are fine with this PR.

Yes, it's fine.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label May 19, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely change, can't wait for it to be merged in. Might make the line more opaque, seems difficult to see on some monitors when testing locally.

Content.Client/Shuttles/UI/BaseShuttleControl.xaml.cs Outdated Show resolved Hide resolved
@dvir001 dvir001 merged commit 74063a0 into new-frontiers-14:master May 20, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants