Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive plots #29

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Interactive plots #29

merged 4 commits into from
Jan 27, 2025

Conversation

KyleQianliMa
Copy link
Collaborator

@KyleQianliMa KyleQianliMa commented Jan 24, 2025

Short description of the changes:

Intractive nature of the plots can be achieved by NavigationToolbar(self.static_canvas, self). This PR mostly tests all interactive components are created correctly to prevent future updates break the interactive toolbar.

EWM Story 8631

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (fc04139) to head (7f09aca).

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #29   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          10       10           
  Lines         763      764    +1     
=======================================
+ Hits          751      752    +1     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* heatmap added, connections
* plot update with fixed size, function clean
* validation logic clean, code clean up
* crosshair plot update fixed
* test updated
* emin and deltae checks from model to view, function updates
* tests for replotting, and variable rename
* darkred color for crosshair added
@mpatrou mpatrou self-requested a review January 27, 2025 17:04
@KyleQianliMa KyleQianliMa merged commit 2568340 into next Jan 27, 2025
3 checks passed
@KyleQianliMa KyleQianliMa deleted the Interactive_plot branch January 27, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants