Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] do not add n_cores to fdr corrector #22

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[FIX] do not add n_cores to fdr corrector #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compose_runner/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
# from neurosynth_compose_sdk.api.compose_api import ComposeApi
# import neurostore_sdk
# from neurostore_sdk.api.store_api import StoreApi
from nimare.correct import FDRCorrector
from nimare.workflows import CBMAWorkflow, PairwiseCBMAWorkflow
from nimare.meta.cbma.base import CBMAEstimator, PairwiseCBMAEstimator
from nimare.nimads import Studyset, Annotation
Expand Down Expand Up @@ -110,7 +111,6 @@ def run_workflow(self, no_upload=False, n_cores=None):
self.create_result_object()
self.upload_results()


def download_bundle(self):
meta_analysis_resp = requests.get(
f"{self.compose_url}/meta-analyses/{self.meta_analysis_id}?nested=true"
Expand Down Expand Up @@ -397,9 +397,9 @@ def load_specification(self, n_cores=None):
cor_mod = import_module(".".join(["nimare", "correct"]))
corrector = getattr(cor_mod, spec["corrector"]["type"])
cor_args = {**spec["corrector"]["args"]} if spec["corrector"].get("args") else {}
if n_cores is not None:
if n_cores is not None and corrector is not FDRCorrector:
cor_args["n_cores"] = n_cores
if cor_args.get("n_iters") is not None:
if cor_args.get("n_iters") is not None and corrector is not FDRCorrector:
cor_args["n_iters"] = int(cor_args["n_iters"])
if cor_args.get("**kwargs") is not None:
for k, v in cor_args["**kwargs"].items():
Expand Down
Loading