module instantiation based on execution order #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jegp
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Sorry for my sluggish response here. But thanks for the efforts, @sheiksadique. It looks good, and the changes are small enough that we can just merge them.
Note, though, that we're reworking the execution structure in #13 as well. So if you have time to chime in, that would be helpful!
|
I think we can close this with the changes to the graph tracing (c736c0e), in #13. Would you mind verifying, @sheiksadique ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cosmetic change but makes it easier/consistent to convert models to sequential.