-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icoh normalisation term and add unit test #366
Conversation
if self.icoh: | ||
self.icoh_val = np.array(self.Pxy / (self.Pxx * self.Pyy)).imag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Denominator term should have the square root taken. Unfortunately the strategy for coh where you square the numerator and take the absolute value doesn't work for icoh since we extract only the imaginary part and this info isn't properly preserved.
Another note, I would argue it is beneficial to expose the At least if the end-user has control over py_neuromodulation/py_neuromodulation/features/coherence.py Lines 82 to 84 in 12d3ed9
What are people's thoughts on exposing this param as a setting? |
Also @tsbinns, it definitely makes sense to expose |
Two things in this PR: