Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH test isotonic calibration on simulation data & FIX correct joblib dependency error #4

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

ENH test isotonic calibration on simulation data & FIX correct joblib dependency error #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fc0cddd
Add files via upload
jzheng17 May 18, 2022
69fccf3
Add files via upload
jzheng17 May 18, 2022
beed66d
Add files via upload
jzheng17 May 18, 2022
87de297
Delete __init__.py
jzheng17 Jun 1, 2022
20eb0c9
Delete test_forest.py
jzheng17 Jun 1, 2022
a897e29
Delete test_tree.py
jzheng17 Jun 1, 2022
63b4156
Create __init__.py
jzheng17 Jun 1, 2022
6cf6d62
Add files via upload
jzheng17 Jun 1, 2022
929b57a
Update forest.py
jzheng17 Jun 1, 2022
5db1419
Update adapted_forest.py
jzheng17 Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions examples/overlapping_gaussians.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

color_dict = {
"HonestRF": "#F41711",
"Iso-HonestRF": "#ce406b",
"RF": "#1b9e77",
"SigRF": "#377eb8",
"IRF": "#fdae61",
Expand All @@ -40,6 +41,18 @@
n_jobs=n_jobs,
),
),
(
"Iso-HonestRF",
CalibratedClassifierCV(
base_estimator=HonestForestClassifier(
n_estimators=n_estimators // clf_cv,
max_features=max_features,
n_jobs=n_jobs,
),
method="isotonic",
cv=clf_cv,
),
),
Comment on lines +44 to +55
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say don't change this file? Leave the honest + IRF for just the notebook. This way the main figure in the repo reflects the paper and isn't as confusing to first time viewers.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, will revert the changes.

(
"IRF",
CalibratedClassifierCV(
Expand Down Expand Up @@ -168,3 +181,4 @@ def likelihood(X):
# ax.set_title("Posterior probabilities")
plt.tight_layout()
plt.savefig("./figures/overlapping_gaussians.png")

Loading