[ENH] Removed local_node_query profile

[rmanaem]

• Closes Remove local_node_query profile from docker-compose.yml #70

Changes proposed in this pull request:

• Removed local_node_query profile
• Updated README.md
• Removed mentions of NB_IS_FEDERATION_API env var

Checklist

This section is for the PR reviewer

• PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
• PR links to GitHub issue with mention Closes #XXXX
• Tests pass
• Checks pass

For new features:

• Tests have been added

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

[alyssadai]

Thanks @rmanaem for the PR!

A few comments from me:

• Could you update the comment for NB_API_QUERY_URL in template.env to specify that this should be the f-API URL, and ensure we use port 8080 in the example to avoid confusion?
• Similarly, I think we should update the description for NB_FEDERATE_REMOTE_PUBLIC_NODES in neurobagel_environment_variables.tsv to mention that when this is false, only locally specified nodes (in local_nb_nodes.json) are queried (or sth to that effect)
• The links in the ## How to use section of the README are out of date. Can you update this to point to the Getting started / Configuring a node sections of the docs?
  • I think it might also be nice to link to the "Configuring a node" page at the top of the environment variable TSV, so users can find more info about the env vars - will leave that up to you
• If it makes sense to you, let's wait until https://github.com/neurobagel/recipes/issues/71 is merged before merging this PR so that this change to the profiles can be versioned

[rmanaem]

I think it might also be nice to link to the "Configuring a node" page at the top of the environment variable TSV, so users can find more info about the env vars - will leave that up to you

Not sure what you had in mind here, do you mean to add another row in the tsv?

[alyssadai]

Not sure what you had in mind here, do you mean to add another row in the tsv?

Whoops, sorry that was a typo from my end. I meant in the template.env file, not the environment variable TSV!

[alyssadai]

one 🍒, otherwise 🧑‍🍳 !

[alyssadai]

Blocked until #75 is addressed

[alyssadai]

This is ready to be merged!

[neurobagel-bot]

🚀 PR was released in v0.1.0 🚀