Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Added NB_QUERY_URL_PATH #69

Merged
merged 5 commits into from
Jul 30, 2024
Merged

[ENH] Added NB_QUERY_URL_PATH #69

merged 5 commits into from
Jul 30, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Jul 26, 2024

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai self-requested a review July 29, 2024 17:40
@alyssadai
Copy link
Contributor

@rmanaem, could you take a look at the merge conflicts?

Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two 🍒, otherwise 🧑‍🍳!

For the sake of coordinating with the changes to the query tool, should we wait to merge this until neurobagel/query-tool#227 is ready to be merged?

template.env Outdated Show resolved Hide resolved
docs/neurobagel_environment_variables.tsv Outdated Show resolved Hide resolved
@@ -76,6 +76,7 @@ services:
environment:
NB_API_QUERY_URL: ${NB_API_QUERY_URL}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thought: I'm realizing that the name NB_API_QUERY_URL is pretty confusing and ambiguous in terms of whether it points to the query tool or API, now that we also have NB_QUERY_URL_PATH.

We should probably consider renaming NB_API_QUERY_URL to sth clearer, either as part of #30 or the issue concerning query tool -> f-API or query tool -> n-API. Maybe you can link this PR there, or vice versa, once the issue is open? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to be addressed in #30 but we can also discuss it in neurobagel/query-tool#225

rmanaem and others added 2 commits July 30, 2024 13:55
@rmanaem rmanaem merged commit 5c931a4 into main Jul 30, 2024
@rmanaem rmanaem deleted the feat-68 branch July 30, 2024 17:59
@alyssadai alyssadai added pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) and removed pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) labels Aug 7, 2024
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NB_QUERY_URL_PATH env var
2 participants