Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] add auth vars to n-API & local query tool and disable by default #67

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[ENH] add auth vars to n-API & local query tool and disable by default #67

merged 1 commit into from
Jul 29, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Jul 25, 2024 •
edited by rmanaem
Loading

Changes proposed in this pull request:

  • n-API and local query tool (pointing to n-API) now can access auth variables
  • auth disabled by default

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem self-requested a review July 26, 2024 15:36
rmanaem
rmanaem approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit 98817ef into main Jul 29, 2024
2 checks passed
@alyssadai alyssadai deleted the add-missing-auth-vars branch July 29, 2024 14:34
@alyssadai alyssadai added pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) and removed pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) labels Aug 7, 2024
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose auth variables to n-API
2 participants
@alyssadai @rmanaem