Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Added NB_FEDERATE_REMOTE_PUBLIC_NODES env var #61

Merged
merged 2 commits into from
May 29, 2024
Merged

[ENH] Added NB_FEDERATE_REMOTE_PUBLIC_NODES env var #61

merged 2 commits into from
May 29, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented May 28, 2024 •
edited by surchs
Loading

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs surchs self-requested a review May 28, 2024 22:40
surchs
surchs approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion for the table, then

🧑‍🍳

docs/neurobagel_environment_variables.tsv Outdated Show resolved Hide resolved
@rmanaem rmanaem merged commit 053b9fd into main May 29, 2024
@rmanaem rmanaem deleted the feat-60 branch May 29, 2024 14:34
@alyssadai alyssadai added pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) and removed pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) labels Aug 7, 2024
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NB_FEDERATE_REMOTE_PUBLIC_NODES env var
3 participants
@rmanaem @surchs @alyssadai