Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix the compatibility workflows #51

Merged
merged 4 commits into from
May 8, 2024
Merged

[FIX] Fix the compatibility workflows #51

merged 4 commits into from
May 8, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented May 3, 2024 •
edited by rmanaem
Loading

  • Closes #

Changes proposed in this pull request:

  • the tests were initially failing because they couldn't even find the test spec
  • I have combined the tests for latest and nightly into one

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem self-requested a review May 8, 2024 16:27
rmanaem
rmanaem requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @surchs!
🍒 Please see the comments for requested changes .

.github/workflows/compatibility.yaml Outdated Show resolved Hide resolved
.github/workflows/compatibility.yaml Outdated Show resolved Hide resolved
.github/workflows/compatibility.yaml Show resolved Hide resolved
.github/workflows/compatibility.yaml Outdated Show resolved Hide resolved
.github/workflows/compatibility.yaml Outdated Show resolved Hide resolved
.github/workflows/compatibility.yaml Outdated Show resolved Hide resolved
.github/workflows/compatibility.yaml Outdated Show resolved Hide resolved
.github/workflows/compatibility.yaml Outdated Show resolved Hide resolved
rmanaem
rmanaem approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@surchs surchs merged commit f7715a2 into main May 8, 2024
@surchs surchs deleted the update_wf branch May 8, 2024 19:41
@alyssadai alyssadai added the pr-tests Add or improve existing tests label Aug 7, 2024
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
pr-tests Add or improve existing tests released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surchs @rmanaem @alyssadai