Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Use docker compose secrets for sensitive credentials #50

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[MNT] Use docker compose secrets for sensitive credentials #50

merged 2 commits into from
Apr 25, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Apr 25, 2024 •
edited by surchs
Loading

Changes proposed in this pull request:

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai marked this pull request as ready for review April 25, 2024 14:06
@surchs surchs self-requested a review April 25, 2024 17:17
surchs
surchs approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice @alyssadai

can confirm that admin_ and user_password no longer show up in docker compose config and also launches

🧑‍🍳

@alyssadai alyssadai merged commit 9626dc1 into main Apr 25, 2024
@alyssadai alyssadai deleted the use-secrets branch April 25, 2024 17:42
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace auth info in .env files with secrets
2 participants
@alyssadai @surchs