Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove default NB_API_QUERY_URL value and fix ports used by full-stack setup script #42

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Apr 16, 2024

Changes proposed in this pull request:

  • Default value for NB_API_QUERY_URL removed, so this value now must always be manually provided
    • Replaced with placeholder in template.env
  • setup.sh and graphdb_setup.sh now use the NB_GRAPH_PORT variable for GraphDB operations (more generic name also suits our plan to eventually have just one configurable port for GraphDB)

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai marked this pull request as ready for review April 16, 2024 21:26
@surchs surchs self-requested a review April 16, 2024 21:38
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai.

Two comments, take a look.

After that 🧑‍🍳

dev/graphdb_setup.sh Show resolved Hide resolved
dev/template.env Outdated Show resolved Hide resolved
@alyssadai alyssadai merged commit 2ca90fa into main Apr 18, 2024
@alyssadai alyssadai deleted the adai/fix-env-var-refs branch April 18, 2024 02:56
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
2 participants