[FIX] Remove default NB_API_QUERY_URL
value and fix ports used by full-stack setup script
#42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB_API_QUERY_URL
in Compose recipes #21setup.sh
steps use host port for GraphDB home when called inside container #39Changes proposed in this pull request:
NB_API_QUERY_URL
removed, so this value now must always be manually providedtemplate.env
setup.sh
andgraphdb_setup.sh
now use theNB_GRAPH_PORT
variable for GraphDB operations (more generic name also suits our plan to eventually have just one configurable port for GraphDB)Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)Closes #XXXX
For new features:
For bug fixes: