Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Regenerate example annotated JSON and JSONLDs using SNOMED assessments #49

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Dec 19, 2024

Changes proposed in this pull request:

  • Labels for controlled terms also updated based on SNOMED vocabulary

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs surchs self-requested a review December 19, 2024 00:12
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alyssadai for the PR.

I guess we'll update the API and query responses once neurobagel/api#390 is addressed?

Changes here look good: 🧑‍🍳

@alyssadai
Copy link
Contributor Author

@surchs yes, I think so. This PR needs to go in first so that tests in the PR for the CLI changes (neurobagel/bagel-cli#410) can pass!

@alyssadai alyssadai merged commit 5690cd4 into main Dec 19, 2024
2 checks passed
@alyssadai alyssadai deleted the deprecate-cogatlas-vocab branch December 19, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all examples and replace CogAtlas with SNOMED
2 participants