Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Update example API responses with derivatives #41

Merged
merged 3 commits into from
Nov 7, 2024
Merged

[ENH] Update example API responses with derivatives #41

merged 3 commits into from
Nov 7, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Nov 7, 2024 •
edited by surchs
Loading

Changes proposed in this pull request:

  • Fixes to make_api_responses.sh to ensure it works 🤡
  • Note that responses from the aggregate OpenNeuro test node do not include any pipeline data because no OpenNeuro datasets have derivatives info in their JSONLDs

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai changed the title Update api responses [ENH] Update example API responses with derivatives Nov 7, 2024
@surchs surchs self-requested a review November 7, 2024 22:07
surchs
surchs approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🧑‍🍳

@alyssadai alyssadai merged commit 66c32ef into main Nov 7, 2024
2 checks passed
@alyssadai alyssadai deleted the update-api-responses branch November 7, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regenerate example API responses
2 participants
@alyssadai @surchs