Code

[ENH] Handle partial nodes success#55

Code

Merged

alyssadai merged 21 commits intomainneurobagel/federation-api:mainfrom handle-partial-nodes-successneurobagel/federation-api:handle-partial-nodes-successCopy head branch name to clipboardJan 14, 2024

+315-29

Commits

Commits on Jan 9, 2024

• add comment explaining FEDERATION_NODES format

  alyssadai

  committed
  8de7904

  Copy full SHA for 8de7904

• implement custom HTTP response for partial success federated query

  Show description for 780b615
  alyssadai

  committed
  780b615

  Copy full SHA for 780b615

• test API path response for partial success federated query

  alyssadai

  committed
  3643130

  Copy full SHA for 3643130

• mock individual node request to assert over combined query response

  alyssadai

  committed
  566e7e1

  Copy full SHA for 566e7e1

Commits on Jan 10, 2024

• add new response model returning errors and node query results

  alyssadai

  committed
  5502a49

  Copy full SHA for 5502a49

• do not use exception object for partial success responses

  alyssadai

  committed
  16114da

  Copy full SHA for 16114da

• rename status key in combined query response

  alyssadai

  committed
  fe9703f

  Copy full SHA for fe9703f

• update response returned when all nodes succeed or fail

  alyssadai

  committed
  9fa13ea

  Copy full SHA for 9fa13ea

• handle network errors in federated query

  alyssadai

  committed
  05be17f

  Copy full SHA for 05be17f

• test federated response given unreachable nodes, create fixture for single matching dataset result

  alyssadai

  committed
  1ea377a

  Copy full SHA for 1ea377a

• refactor tests of federated query response into separate module

  alyssadai

  committed
  e338599

  Copy full SHA for e338599

• test response when queries to all nodes fail

  alyssadai

  committed
  caa3933

  Copy full SHA for caa3933

• test response when queries to all nodes succeed

  alyssadai

  committed
  d0f858b

  Copy full SHA for d0f858b

• update comments and type hints

  alyssadai

  committed
  4b9e926

  Copy full SHA for 4b9e926

• turn status of node responses into enum

  alyssadai

  committed
  e1eafdc

  Copy full SHA for e1eafdc

• use model for node error in federated query response

  alyssadai

  committed
  b7fbb60

  Copy full SHA for b7fbb60

Commits on Jan 11, 2024

• switch to sending requests to nodes asynchronously

  alyssadai

  committed
  cf8d392

  Copy full SHA for cf8d392

• update mocked get function in tests to be async

  alyssadai

  committed
  83a50cd

  Copy full SHA for 83a50cd

• update return type hint

  alyssadai

  committed
  ab50b37

  Copy full SHA for ab50b37

Commits on Jan 14, 2024

• make code a bit cleaner

  Show description for f65aff8
  

  alyssadai

  and

  surchs

  authored
  f65aff8

  Copy full SHA for f65aff8

• rename fixture for mocked data

  alyssadai

  committed
  f3640e6

  Copy full SHA for f3640e6