-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Make root_path
for app configurable
#154
Conversation
Reviewer's Guide by SourceryThis pull request introduces the ability to configure the root path for the FastAPI application, which is particularly useful when the application is behind a proxy. The root path is now configurable via the Sequence diagram for API documentation access with configurable root pathsequenceDiagram
actor User
participant Browser
participant API
User->>Browser: Access API docs
Browser->>API: GET {root_path}/docs
Note over API: Uses configured root_path
API->>Browser: Return Swagger UI HTML
Note over Browser: Links use {root_path}/openapi.json
Browser->>API: GET {root_path}/openapi.json
API->>Browser: Return OpenAPI spec
Browser->>User: Display API documentation
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 97.17% 97.37% +0.20%
==========================================
Files 23 23
Lines 707 724 +17
==========================================
+ Hits 687 705 +18
+ Misses 20 19 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @alyssadai, one question about the trailing slashes.
Otherwise 🧑🍳
Changes proposed in this pull request:
NB_FAPI_ROOT_PATH
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes:
Summary by Sourcery
Enhancements:
/fapi/v1
.