Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Ensure Google auth token is forwarded in request to n-API #132

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[FIX] Ensure Google auth token is forwarded in request to n-API #132

merged 1 commit into from
Oct 31, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 31, 2024 •
edited
Loading

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added release Create a release when this PR is merged pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) labels Oct 31, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11619751568

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 96.948%
Totals Coverage Status
Change from base Build 11565296257: 0.005%
Covered Lines: 667
Relevant Lines: 688
💛 - Coveralls

surchs
surchs approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit 6f44b81 into main Oct 31, 2024
7 checks passed
@alyssadai alyssadai deleted the pass-on-token branch October 31, 2024 21:04
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

🚀 PR was released in v0.4.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

f-API does not pass on auth token for federated query
3 participants
@alyssadai @coveralls @surchs