-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication to /query
route
#104
Conversation
Pull Request Test Coverage Report for Build 9929726741Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great stuff @alyssadai 🎉. All looks reasonable to me, and good job using trustworthy external libraries for all of this! I left a couple comments - mainly for understanding or clarity.
But good to go as is, just take a quick look and then 🧑🍳
Co-authored-by: Sebastian Urchs <[email protected]>
🚀 PR was released in |
Changes proposed in this pull request:
/query
route now expects an authorization token by defaultNB_QUERY_CLIENT_ID
: Client ID of query toolNB_ENABLE_AUTH
: Whether or not to enable authentication (will determine if client ID is also checked)Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: