Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Document bagel derivatives command, add harmonized variables list #235

Merged
merged 20 commits into from
Oct 31, 2024
Merged

[ENH] Document bagel derivatives command, add harmonized variables list #235

merged 20 commits into from
Oct 31, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 30, 2024 •
edited by surchs
Loading

Other changes proposed in this pull request:

  • Add mkdocs-open-in-new-tab plugin to auto open all external links in new tab
  • Add new page for summary of currently harmonized variables
  • Link to new GH Discussion for proposing/endorsing a new variable for inclusion in the data model

Checklist

Please leave checkboxes empty for PR reviewers

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF]) see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Checks pass

@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit 7c23bd4
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/6723d0ed317acf0008fa21f5
😎 Deploy Preview https://deploy-preview-235--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alyssadai alyssadai changed the title [ENH] Document bagel derivatives command + minor updates [ENH] Document bagel derivatives command, add harmonized variables list Oct 31, 2024
@alyssadai alyssadai marked this pull request as ready for review October 31, 2024 02:10
@surchs surchs self-requested a review October 31, 2024 15:39
surchs
surchs approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai!
I left some suggestions for you to look at,

with those 🧑‍🍳

docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Show resolved Hide resolved
docs/variables.md Outdated Show resolved Hide resolved
docs/variables.md Outdated Show resolved Hide resolved
@alyssadai alyssadai merged commit 469daa9 into main Oct 31, 2024
5 of 6 checks passed
@alyssadai alyssadai deleted the update-cli-docs branch October 31, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neurobagel service name discrepancy in docs Document derivatives command for bagel-cli
2 participants
@alyssadai @surchs