Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Warn against having local f-API address in local_nb_nodes.json, link fixes #233

Merged
merged 8 commits into from
Oct 30, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 29, 2024

This PR also fixes some links and updates the Markdown Link Check to ignore some non-dereferenceable URLs.

Checklist

Please leave checkboxes empty for PR reviewers

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF]) see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Checks pass

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit 20407a0
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/672147ae3b307700089c432f
😎 Deploy Preview https://deploy-preview-233--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alyssadai alyssadai changed the title [ENH] Warn against including local f-API address in local_nb_nodes.json [MNT] Warn against including local f-API address in local_nb_nodes.json Oct 29, 2024
@alyssadai alyssadai changed the title [MNT] Warn against including local f-API address in local_nb_nodes.json [MNT] Warn against having local f-API address in local_nb_nodes.json, link fixes Oct 29, 2024
@alyssadai alyssadai mentioned this pull request Oct 29, 2024
@surchs surchs self-requested a review October 30, 2024 01:00
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai, looks good!

🧑‍🍳

docs/maintaining.md Show resolved Hide resolved
@alyssadai alyssadai merged commit 681368d into main Oct 30, 2024
6 checks passed
@alyssadai alyssadai deleted the adai/update-docs branch October 30, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn against including an f-API in local_nb_nodes.json Datalad link missing
2 participants