Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Deprecate non-federated query tool config, bump Docker Compose required ver. #217

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Aug 8, 2024

Changes proposed in this pull request:

  • Query tool is now specified to point only to an f-API instance
  • Minor formatting edits for readability
  • Minimum Docker Compose version updated to one that supports secrets via environment vars

Checklist

Please leave checkboxes empty for PR reviewers

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF]) see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Checks pass

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit d72b1f9
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/66b650905bbbcd00081ea3f8
😎 Deploy Preview https://deploy-preview-217--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- older versions don't support environment variable secrets
@alyssadai alyssadai changed the title [MNT] Deprecate non-federated query tool deployment config [MNT] Deprecate non-federated query tool config, bump Docker Compose required ver. Aug 8, 2024
@surchs surchs self-requested a review August 9, 2024 14:08
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment -> 🧑‍🍳

docs/config.md Outdated Show resolved Hide resolved
@alyssadai
Copy link
Contributor Author

alyssadai commented Aug 9, 2024

Hey @surchs, just to wrap up a small stale issue into this PR, I added a commit c92a4ab to address Barbara's request for more clarity concerning local_nb_nodes.json #204 (since I'm editing the config page anyways).

Let me know if you think the addition is clear enough that local_nb_nodes.json should only include n-APIs.

@surchs
Copy link
Contributor

surchs commented Aug 9, 2024

Hey @surchs, just to wrap up a small stale issue into this PR, I added a commit c92a4ab to address Barbara's request for more clarity concerning local_nb_nodes.json #204 (since I'm editing the config page anyways).

Let me know if you think the addition is clear enough that local_nb_nodes.json should only include n-APIs.

Yep, that is a good way to address it I think. Thanks for that!

@alyssadai alyssadai merged commit 3e2ae59 into main Aug 9, 2024
6 checks passed
@alyssadai alyssadai deleted the deprecate-local-query-config branch August 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants