Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Update the graph reset docs to reflect volumes #198

Merged
merged 10 commits into from
May 16, 2024
Merged

Conversation

surchs
Copy link
Contributor

@surchs surchs commented May 14, 2024

Related to neurobagel/recipes#57

Changes proposed in this pull request:

Checklist

Please leave checkboxes empty for PR reviewers

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF]) see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Checks pass

Copy link

netlify bot commented May 14, 2024

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit c503729
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/6645f1983a0132000831cc42
😎 Deploy Preview https://deploy-preview-198--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alyssadai alyssadai self-requested a review May 15, 2024 15:47
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @surchs for addressing this so quickly!

Added some suggestions for clarity, and also a question about formatting as I'm not sure the docs preview is rendering some of the bullet points correctly.

docs/maintaining.md Show resolved Hide resolved
docs/maintaining.md Outdated Show resolved Hide resolved
docs/maintaining.md Outdated Show resolved Hide resolved
docs/maintaining.md Show resolved Hide resolved
docs/maintaining.md Show resolved Hide resolved
docs/maintaining.md Outdated Show resolved Hide resolved
docs/maintaining.md Show resolved Hide resolved
docs/maintaining.md Show resolved Hide resolved
docs/maintaining.md Outdated Show resolved Hide resolved
docs/maintaining.md Outdated Show resolved Hide resolved
@surchs
Copy link
Contributor Author

surchs commented May 15, 2024

The ordered lists disappearing is due to tailwind. I fixed the lists, but this warrants a closer look: #203

@surchs surchs requested a review from alyssadai May 15, 2024 22:59
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two 🍒, otherwise good to go!

docs/maintaining.md Outdated Show resolved Hide resolved
docs/maintaining.md Outdated Show resolved Hide resolved
surchs and others added 2 commits May 16, 2024 07:44
Co-authored-by: Alyssa Dai <[email protected]>
Co-authored-by: Alyssa Dai <[email protected]>
@surchs surchs merged commit fb535d7 into main May 16, 2024
6 checks passed
@surchs surchs deleted the graph_reset_update branch May 16, 2024 12:14
@alyssadai alyssadai mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearer workflow flow for updating data in an existing graph
2 participants