Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update local node and local federation setup instructions #170

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Feb 23, 2024

Closes #116

Other changes proposed in this pull request:

  • Standardized names of .env files to use in local deployments for simplicity
  • Fixed example for API_QUERY_URL in local federation
  • Provide node name examples with spaces

Checklist

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit e50d561
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/65dd16ed0e54ae00081ab47d
😎 Deploy Preview https://deploy-preview-170--neurobagel-documentation.netlify.app/infrastructure
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review February 23, 2024 14:23
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai for the quick fix! I left some comments for things I think need another look (e.g. the link failure is actually meaningful). Please take a look and address, rest is great!

🧑‍🍳

docs/federate.md Outdated Show resolved Hide resolved
docs/federate.md Show resolved Hide resolved
docs/federate.md Show resolved Hide resolved
docs/infrastructure.md Show resolved Hide resolved
docs/infrastructure.md Outdated Show resolved Hide resolved
docs/infrastructure.md Outdated Show resolved Hide resolved
docs/infrastructure.md Show resolved Hide resolved
@alyssadai alyssadai merged commit d571ef8 into main Feb 26, 2024
6 checks passed
@alyssadai alyssadai deleted the update-deploy-instructions branch February 26, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to update or grant more permissions to a created GraphDB user
2 participants