-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Change the linked examples to recipe repo #158
Conversation
✅ Deploy Preview for neurobagel-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @surchs, sorry for the delay with this review!
The changes are looking good, but I noticed there are still a few remaining sections on this docs page that refer to files from the neurobagel/api repo (I did a quick search for "api repo" to double check), which should also be updated as part of this PR.
Since I can't seem to comment directly on lines that weren't changed, I've summarized these in my last comment below!
Co-authored-by: Alyssa Dai <[email protected]>
And also introduce a nice merge conflict because someone forget to merge first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @surchs! Some final corrections below with regards to repo naming, and I think we're gtg 🧑🍳
Co-authored-by: Alyssa Dai <[email protected]>
…e144 A merge conflict? At this time of day?
While we're at it, just merge some more
The dead links check failing is expected, because these links are anticipating that neurobagel/recipes#15 will be merged as is. |
recipes
repo #144Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX