Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Refactor dataset size request into separate function #235

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Dec 1, 2023

Changes proposed in this pull request:

  • Request for sizes of a list of matching datasets now in a separate function from primary subject query

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@coveralls
Copy link
Collaborator

coveralls commented Dec 1, 2023

Pull Request Test Coverage Report for Build 7065779048

  • 39 of 39 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 99.771%

Totals Coverage Status
Change from base Build 7052301596: 0.008%
Covered Lines: 873
Relevant Lines: 875

💛 - Coveralls

@alyssadai alyssadai marked this pull request as ready for review December 1, 2023 20:19
@rmanaem rmanaem self-requested a review December 1, 2023 21:23
Copy link
Collaborator

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @alyssadai!
I think we can remove the TODO above mock_post_query_to_graph in conftest.py and then 🧑‍🍳

@alyssadai alyssadai merged commit 8fa6be3 into main Dec 1, 2023
4 checks passed
@alyssadai alyssadai deleted the refactor-datasize-size-request branch December 1, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor request for total number of subjects in matching datasets into separate function
3 participants