-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Make data upload script backend responsive #205
[ENH] Make data upload script backend responsive #205
Conversation
Pull Request Test Coverage Report for Build 6601490156
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
However, I do have a question and a suggestion.
I'm curious to know why you capitalized the messages? Is it a convention?
🍒 : I think it's a good idea to rename either graph-db
or use-graphdb-syntax
in code for the sake of clarity e.g., use-GraphDB-syntax
.
Mostly so that it is easy for the user to visually distinguish the progress messages from the script itself (e.g.
Good point! I've renamed the |
Closes #204
Changes proposed in this pull request:
Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: