Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use proper tls client config in neuro-sdk #2931

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andriihomiak
Copy link
Contributor

@andriihomiak andriihomiak commented Mar 14, 2023

This caused a deprecation warning in 3.10, which messes up tests, e.g. platform-monitoring

@andriihomiak andriihomiak added the enhancement New feature or request label Mar 14, 2023
@andriihomiak andriihomiak self-assigned this Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c5a6ec5) 73.47% compared to head (56a383c) 73.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2931   +/-   ##
=======================================
  Coverage   73.47%   73.48%           
=======================================
  Files          70       70           
  Lines       12328    12331    +3     
  Branches     2266     2267    +1     
=======================================
+ Hits         9058     9061    +3     
  Misses       2954     2954           
  Partials      316      316           
Impacted Files Coverage Δ
neuro-sdk/src/neuro_sdk/_config_factory.py 91.52% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andriihomiak andriihomiak marked this pull request as draft March 14, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant