-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanya explanations #384
Open
VanyaBK
wants to merge
26
commits into
main
Choose a base branch
from
vanya_explanations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Vanya explanations #384
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
5c79a07
Update prompt_based.py to include generation of explanations
VanyaBK da7875c
Update prompt_template to include explanations in the examples of met…
VanyaBK 82f954a
Update instr_parser_prompt.py to include explanations in the demonstr…
VanyaBK d0cd15c
Update prompt_based.py to fix the length issues in the PR
VanyaBK 58038d9
Update prompt_based.py to fix the trailing space PR issues
VanyaBK 49a41d9
Update instr_parser_prompt.py to fix PR length issues
VanyaBK 7b6cd50
Update prompt_based.py
VanyaBK 7301726
Update instr_parser_prompt.py
VanyaBK dfb2e06
Update instr_parser_prompt.py
VanyaBK 6e36a03
Update prompt_based.py
VanyaBK 0802cdd
Update prompt_based.py
VanyaBK 4665121
Update prompt_based.py
VanyaBK 2d81bc3
Update dataset_generator_test.py
VanyaBK 16fdc0e
Update dataset_generator_test.py
VanyaBK d48d252
Update dataset_generator_test.py
VanyaBK 28aadad
Update dataset_generator_test.py
VanyaBK 49caf60
Update dataset_generator_test.py
VanyaBK a4eebb8
Update dataset_processor_test.py
VanyaBK 1b0ffc7
Update dataset_generator_test.py
VanyaBK 057d42b
Update dataset_generator_test.py
VanyaBK f24b344
Update dataset_generator_test.py
VanyaBK 79af8e2
Update dataset_generator_test.py
VanyaBK cb0bf99
Update mock_api.py
VanyaBK 1af0de6
Update dataset_generator_test.py
VanyaBK 74213f8
Update dataset_processor_test.py
VanyaBK bc5de3d
Update mock_api.py
VanyaBK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest that we just call this
explanation_col
to be consistent. Also, it's not clear what an explanation is. I'd suggest that you expand the docstring and describe what all the variables are.