Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Magento 2 code #1462

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Removed Magento 2 code #1462

merged 1 commit into from
Aug 22, 2024

Conversation

sreichel
Copy link
Collaborator

Magerun pull-request check-list:

  • Pull request against develop branch (if not, just close and create a new one against it)
  • README.md reflects changes (if any)

Changes proposed in this pull request:

  • removed all M2 related code

@sreichel sreichel requested a review from cmuench August 22, 2024 06:42
Copy link
Member

@cmuench cmuench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow. What a big cleanup.
Did not find anything on a quick review. Tests are also running.

@sreichel
Copy link
Collaborator Author

I have some tests that fail locally like ...

1) N98\Magento\Command\System\Setup\RemoveCommandTest::testRemoveModule
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "Mage_Core_Model_Resource" does not exist

/var/www/html/tests/N98/Magento/Command/System/Setup/RemoveCommandTest.php:27

2) N98\Magento\Command\System\Setup\RemoveCommandTest::testRemoveBySetupName
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "\Mage_Core_Model_Resource" does not exist

/var/www/html/tests/N98/Magento/Command/System/Setup/RemoveCommandTest.php:65

3) N98\Magento\Command\System\Setup\RemoveCommandTest::testRemoveBySetupNameFailure
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "\Mage_Core_Model_Resource" does not exist

/var/www/html/tests/N98/Magento/Command/System/Setup/RemoveCommandTest.php:107

... but they fail on current develop branch too?

@sreichel
Copy link
Collaborator Author

Merged ... to make some progess. Everything else in a final review.

@sreichel sreichel merged commit e5e089f into netz98:develop Aug 22, 2024
20 checks passed
@sreichel sreichel deleted the dead-m2-code branch August 22, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants