clients/, common/, drivers/: refactor debug/log strerror to helper funcs #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(8f10093) Whoops, missed that |
desertwitch
commented
Sep 15, 2024
jimklimov
added
enhancement
refactor/fightwarn
jimklimov
requested changes
Sep 22, 2024
jimklimov
approved these changes
Sep 23, 2024
desertwitch
force-pushed
the
strerror-to-helper
branch
from
783b1de
to
096535d
Compare
Signed-off-by: desertwitch <[email protected]>
desertwitch
force-pushed
the
strerror-to-helper
branch
from
096535d
to
ee7fba1
Compare
|
@desertwitch : what's with the force-pushes, they seem to bring no new diff... rebases over current target? typos in commit comments? Should I wait before merging? :) |
Just squashing/cleaning up before merge, good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had some time to kill on public transportation and did some more detective work, refactors all found occurrences of non-specific
strerrorfunctions into their respective helper functionsupslog_with_errno()andupsdebug_with_errno()addresses and possibly fixes #2396