Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parallel IPMI scanning in nut-scanner, and address some valgrind complaints #2528

Merged
merged 18 commits into from
Jul 11, 2024

Conversation

jimklimov
Copy link
Member

Addresses part of #2511
Closes: #2523

@jimklimov jimklimov added bug enhancement nut-scanner CI Entries related to continuous integration infrastructure (historically also recipes like Makefiles) labels Jul 10, 2024
@jimklimov jimklimov added this to the 2.8.3 milestone Jul 10, 2024
…ols#2523 until it is in the codebase"

This reverts commit d710ade:
the feature is here now.

Signed-off-by: Jim Klimov <[email protected]>
…r.c, NEWS.adoc: implement parallel scanning for remote IPMI controllers [networkupstools#2523]

Signed-off-by: Jim Klimov <[email protected]>
…pstools#2511]

* Clearly name "thread-ready" scanning methods that can be used
  standalone or from pthread_create() constraints
* Settle on "thready" methods freeing caller's data (so we do not
  worry about doing it after the parallel loops, or at a wrong
  moment before)
* Unify code mark-up in the files to facilitate later comparisons
* Update some comments

Signed-off-by: Jim Klimov <[email protected]>
…mment what we do about "dirname" with and without realpath() support

Signed-off-by: Jim Klimov <[email protected]>
…() the loaded library modules [networkupstools#2511]

Avoid some memory leak reports

Signed-off-by: Jim Klimov <[email protected]>
…rack semaphore usage in debugger

Signed-off-by: Jim Klimov <[email protected]>
…rain libnetsnmp leak reports [networkupstools#2511]

It seems that although `init_snmp()` is called once, every use of the
library initializes some data which it then does not release, at least
on the test system here.

Signed-off-by: Jim Klimov <[email protected]>
…s/valgrind/.valgrind.supp: constrain warnings about library methods [networkupstools#2511]

Signed-off-by: Jim Klimov <[email protected]>
…evise trace-logging and comment markup [networkupstools#2511]

Signed-off-by: Jim Klimov <[email protected]>
@jimklimov jimklimov merged commit e6e32a6 into networkupstools:master Jul 11, 2024
27 of 31 checks passed
@jimklimov jimklimov deleted the issue-2523 branch July 11, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI Entries related to continuous integration infrastructure (historically also recipes like Makefiles) enhancement nut-scanner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Want to implement parallel nut-scanner scanning support for IPMI
1 participant