Teach nut-scanner to parallelize scans across many IP address ranges
#2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parate method [networkupstools#2244] Allow for some shorter indentation Signed-off-by: Jim Klimov <[email protected]>
…un-indent it some more [networkupstools#2244] Signed-off-by: Jim Klimov <[email protected]>
…workupstools#2244] Signed-off-by: Jim Klimov <[email protected]>
…intouts [networkupstools#2244] Signed-off-by: Jim Klimov <[email protected]>
…overed subnets are filtered out [networkupstools#2244] Signed-off-by: Jim Klimov <[email protected]>
…ict, NEWS.adoc: handle_arg_cidr(): add `-m auto*/ADDRLEN` mode [networkupstools#2244] Signed-off-by: Jim Klimov <[email protected]>
… "arg_addr" [networkupstools#2244] Avoid warning about clash with a global variable. Fallout of refactoring original code into a method. Also make it `const` as we do not change the original value anyway. Signed-off-by: Jim Klimov <[email protected]>
… subnet by family before checking for mask length [networkupstools#2244] Signed-off-by: Jim Klimov <[email protected]>
…() not atoi() [networkupstools#2244] Signed-off-by: Jim Klimov <[email protected]>
…t atol() [networkupstools#2244] Signed-off-by: Jim Klimov <[email protected]>
… before we declare vars and types Signed-off-by: Jim Klimov <[email protected]>
… ip_range_t definition into header [networkupstools#2244] Signed-off-by: Jim Klimov <[email protected]>
… for ip_ranges[] list and helper metadata, and methods as part of libnutscan [networkupstools#2244, networkupstools#2511] Not bumping library version, because it was recently bumped as part of other PRs about this issue. Technically the scope of the library has been changed by new exported methods and header lines. Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…/cidr IPs [networkupstools#2519] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
….3 man pages Signed-off-by: Jim Klimov <[email protected]>
…orkupstools#2244, networkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
…nts [networkupstools#2244, networkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
… comments [networkupstools#2244, networkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
…ction [networkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
…t_ip<=irl.stop_ip in alphanumeric comparison order [networkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
…#2244, networkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
…orkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
…etworkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
…orkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
…tworkupstools#2511] Signed-off-by: Jim Klimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since work on issue #2244 began,
nut-scannerlearned to request scans for many individual IP addresses or ranges in one call. That was functional, but slow (as described in issue #2511) due to each range being scanned independently, until its timeout was hit.This PR adds a way to iterate the IP address range collections, and extends the iterated multiple-IP methods for "Old NUT", SNMP, NetXML and IPMI (not parallelized yet!) to iterate not over a single set of
start_ip .. end_ipbut over all requested addresses in the same thread pool (per bus). For a small series of single-IP ranges this yields a very quick scan (not constrained by a sum of timeouts times the amount of such ranges).