Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/Makefile.am, tools/nut-scanner/Makefile.am: Introduce libcommonstr.la #2478

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

jimklimov
Copy link
Member

Address part of #1316

A smaller helper library than libcommonclient.la which is sometimes an overkill, e.g. in nut-scanner where the libupsclient.so/.dll is loaded dynamically for "Old NUT" scans and there is no specific use for object files included into libcommonclient.la.

More use-cases with DMF codebase (currently not yet upstreamed).

Combined from a series of commits like

@jimklimov jimklimov added nut-scanner refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings DMF NUT Data/Dynamic Mapping File/Format/Functionality feature C-str Issues and PRs about C/C++ methods, headers and data types dealing with strings and memory blocks labels Jun 15, 2024
@jimklimov jimklimov added this to the 2.8.3 milestone Jun 15, 2024
@AppVeyorBot

This comment was marked as resolved.

…`libcommonstr.la` recipe

A smaller helper library than `libcommonclient.la` which is sometimes an
overkill, e.g. in `nut-scanner` where the `libupsclient.so/.dll` is loaded
dynamically for "Old NUT" scans and there is no specific use for object
files included into `libcommonclient.la`.

More use-cases with DMF codebase (currently not yet upstreamed).

Combined from a series of commits like
* 3ba6b57
* c418728
* 5f16b7b
* bc4cd95

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this pull request Jun 18, 2024
jimklimov added a commit to jimklimov/nut that referenced this pull request Jun 18, 2024
@jimklimov jimklimov merged commit 8ba17e0 into networkupstools:master Jun 24, 2024
30 checks passed
@jimklimov jimklimov deleted the issue-1316-libcommonstr branch June 24, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-str Issues and PRs about C/C++ methods, headers and data types dealing with strings and memory blocks DMF NUT Data/Dynamic Mapping File/Format/Functionality feature nut-scanner refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants