-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bicker serial driver #2448
Merged
Merged
Add Bicker serial driver #2448
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a56281b
bicker_ser: Bicker UPSes based on PSZ-1063
ntd 021472d
bicker_ser: add shutdown support
ntd 3ae6b50
data/driver.list.in: add bicker_ser based UPSes
ntd 0b53475
bicker_ser: add big-endian platform support
ntd 6538f2f
bicker_ser: use length macros to increase expressiveness
ntd 67ffe25
bicker_ser: add manpage
ntd ffd42d1
NEWS.adoc: announce bicker_ser driver [#2318]
ntd d5e7ce5
bicker_ser: update protocol documentation
ntd 162e39e
bicker_ser: explicitly pass the command index
ntd 8abde1a
bicker_ser: refactor to allow more complex packet handling
ntd eaddb34
bicker_ser: add more state variables
ntd c659e31
bicker_ser: use variable for low battery limit
ntd a4c3767
bicker_ser: add parameter support
ntd ee71353
bicker_ser: differentiate between error and unsupported
ntd c9fed62
bicker_ser: fix string dstate setting
ntd c9ba796
bicker_ser: fix alignment and endianness problems
ntd beb26a6
bicker_ser: cosmetic fixes
ntd 0c80ece
bicker_ser: use uint8_t for bytes instead of char
ntd 4a33b3a
bicker_ser: use proper format modifiers in logs
ntd c78524c
bicker_ser: refactor to clarify packet manipulation
ntd 27bdc87
bicker_ser: make parameter handling less error prone
ntd fca9957
bicker_ser: add sanity checks to bicker_set
ntd 4cbe12d
bicker_ser: expose mappable parameters
ntd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
BICKER_SER(8) | ||
============= | ||
|
||
NAME | ||
---- | ||
|
||
bicker_ser - Driver for Bicker DC UPS via serial port connections | ||
|
||
SYNOPSIS | ||
-------- | ||
|
||
*bicker_ser* -h | ||
|
||
*bicker_ser* -a 'UPS_NAME' ['OPTIONS'] | ||
|
||
NOTE: This man page only documents the hardware-specific features of the | ||
*bicker_ser* driver. For information about the core driver, see | ||
linkman:nutupsdrv[8]. | ||
|
||
SUPPORTED HARDWARE | ||
------------------ | ||
|
||
*bicker_ser* supports all Bicker UPSes shipped with the PSZ-1053 extension | ||
module such as UPSIC-1205, UPSIC-2403, DC2412-UPS and DC2412-UPS-LD. | ||
|
||
CABLING | ||
------- | ||
|
||
The needed cable is a standard pin-to-pin serial cable with pins 2, 3 and 5 | ||
(on DB9 connector) connected. | ||
|
||
EXTRA ARGUMENTS | ||
--------------- | ||
|
||
This driver supports no extra arguments from linkman:ups.conf[5]. | ||
|
||
INSTANT COMMANDS | ||
---------------- | ||
|
||
*shutdown.return*:: | ||
Turn off the load and return when power is back. | ||
|
||
KNOWN ISSUES AND BUGS | ||
--------------------- | ||
|
||
*ups.delay.shutdown is not honored*:: | ||
Although that delay is properly set when sending the shutdown command, it seems | ||
some UPS ignore it and use a fixed 2 seconds delay instead. | ||
|
||
AUTHOR | ||
------ | ||
|
||
Nicola Fontana <[email protected]> | ||
|
||
SEE ALSO | ||
-------- | ||
|
||
The core driver: | ||
~~~~~~~~~~~~~~~~ | ||
|
||
linkman:nutupsdrv[8] | ||
|
||
Internet resources: | ||
~~~~~~~~~~~~~~~~~~~ | ||
|
||
The NUT (Network UPS Tools) home page: https://www.networkupstools.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity: This mixed casing of
Vac
scratched my eye a bit - I'm used to seeing acronyms as upper-cased. But lower-caseac
/dc
seem to be the modern IEEE recommendation, according to internet discussions of many others whose eyes this has also got irritated :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copy&pasted the
adelsystem_cbi
announcement, that seems the closer one to thebicker_ser
description.But now the protocol is based on the UPS-Gen² software user manual so, according to that manual, more UPSes are supported (even USB one):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the end I think that description is at least incomplete. We'll see if Bicker has anything to say about that.