Fix fallout of TOCTOU fixes for socket file non-default permissions #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimklimov
added
bug
service/daemon start/stop
…/... for socket file [networkupstools#2185] Signed-off-by: Jim Klimov <[email protected]>
…e non-default permissions [networkupstools#2185] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
force-pushed
the
issue-2185
branch
from
7329c5e to
3d86516
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2185
Follows-up from: #2096
Sockets can not be
open()ed to get a file descriptor forfchown(),fstat()and similar operations on many platforms tried. Filenames must be used, it seems (something TOCTOU warns against). If there are better ideas later - apply them. For now, try to be safe - but fall back to practical where needed.